Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segments not filtering correctly #15163

Closed
ghost opened this issue Nov 15, 2019 · 12 comments
Closed

Segments not filtering correctly #15163

ghost opened this issue Nov 15, 2019 · 12 comments
Labels
answered For when a question was asked and we referred to forum or answered it.

Comments

@ghost
Copy link

ghost commented Nov 15, 2019

I got notified about an issue and could reproduced it with different installations of matomo 3.12.0

Examples

Downloads

  • select a website
  • go to Behaviour -> Downloads
  • create a new segment
  • select Download URL is a complete URL and apply
    In my opinion there should only be one entry with this full URL and nothing else.
  • in my example https://some-domain.tld/saas/_images/outlook_configuration.png
    downloads-all
    Downloads-segment
    downloads-segment-applied

Pages

  • select a website
  • go to Behaviour -> Pages
  • create a new segment
  • select Action URL contains enter a par of an existing URL in my example saas
  • the same result if i use Page URL instead
  • the first entry is correct but in the rest i cant find any sign of saas in the URL's
    pages-all
    pages-action-url
    action-url-result
    page-page-url-segment
    page-url-result

Maybe am i missing something completely but it seems wrong for me.

@fe-hicking
Copy link

fe-hicking commented Nov 15, 2019

Related:

https://forum.matomo.org/t/filter-page-urls-by-segments/34859

To us this is a critical bug. One of the main tasks in Matomo is no longer working as we and clients expect it. This should not have been implemented in a non-breaking minor release.

It needs to be made an optional segment option. Until it becomes optional in 4.0.x it should be reverted in a new regression release of 3.x.

@fe-hicking
Copy link

Related: #15133

IMO this issue is important.

@tsteur
Copy link
Member

tsteur commented Nov 15, 2019

See #15130 (comment) on how to restore old behaviour. We're not planning to restore the previous behaviour as default behaviour unfortunately. Segment feature is supposed to work like it is implemented now and it was buggy how it worked before. We totally understand this is frustrating but there's no way we can make everyone happy unfortunately and we followed to what most users are wanting/expecting and how it works on other analytics solutions. The feature you're referring to be a "filter" which we don't have yet. Custom Reports supports it though.

@tsteur tsteur closed this as completed Nov 15, 2019
@tsteur tsteur added the answered For when a question was asked and we referred to forum or answered it. label Nov 15, 2019
@PeteTrombone
Copy link

Why is this issue closed? There is still no solution for many matomo users.
Our company have the same problem like TheFirstGoodmaN and fe-hicking. Custom Reports, Custom Dimensions don't bring the same result an to disable the new behaviour is no solution for us.

Like the example of TheFirstGoodmaN, there is no difference between page-url and action-url anymore.
As far as I know the "bug" referred only to the parameter "Page-URL", why was the function also changed for the parameter "Action-URL"?

In addition, we now even have a big data protection problem, because more data is displayed as desired/allowed. In our case, we are no longer compliant with gdpr and we can not use this anymore.

@tsteur
Copy link
Member

tsteur commented Nov 19, 2019

@PeteTrombone just to understand why do you not want to disable this feature to have old behaviour? In general we can't have the same feature working in two different ways and everyone would expect to behave it one or the other way. We're really talking of one feature here. Be keen to hear your thoughts on why Custom Reports did not do the trick here and what we can maybe improve. Feel free to get in touch with our support about that: shop at innocraft.com

@viezel
Copy link

viezel commented Dec 16, 2019

@tsteur just looping back here. I have another scenario using Events API where it makes no sense at all.

Piwik::api('Events.getCategory', [
    ... // some params that does not matter for this example
    'segment' => 'eventAction==ViewScreen;eventCategory==ContractSigned',
    'secondaryDimension' => 'eventName'
]);

You should think that the above code would filter through all the events and only show events that

  1. have eventAction ViewScreen
  2. have eventCategory = ContractSigned

In 3.11 we get a list of 30 events matching , but in 3.12 - we get a list of all events (1000+)?
I dont follow how this cannot be a bug. Are we sure this is the behaviour we want?

@tsteur
Copy link
Member

tsteur commented Dec 16, 2019

@viezel this is really the correct behaviour and how segmentation should work. You're really more after a filter here which we don't really have yet in Matomo except for custom reports.

@viezel
Copy link

viezel commented Dec 17, 2019

@tsteur I see. Then please let me know how you will only data with these 2 conditions I showed?

because filter_pattern cannot do that, so I cannot see how to achieve this now

@tsteur
Copy link
Member

tsteur commented Dec 17, 2019

Then please let me know how you will only data with these 2 conditions I showed?

You would either need to manually filter this data if that's an option (possibly not since you have two different segments applied and you probably wouldn't get the data you want) or you use custom reports where you can apply a filter.

I totally understand this is frustrating. This is how people expect segmentation to work and unfortunately we don't have yet such a filter feature in core that you are after.

@viezel
Copy link

viezel commented Dec 17, 2019

But Filters must be top priority for you in next release, right?
I really don’t know any software platforms that takes fix/changes features with the argument “we don’t support this anymore”.
Even through we have custom reports, it will takes days to regenerate reports going back in time. It’s not really a valid solution for ongoing businesses.

We at Napp really like the mission and product of Matomo, but this move is really bad. It’s not even considered a breaking change in your changelog 😳

@viezel
Copy link

viezel commented Dec 17, 2019

4CA3BFCF-6189-4264-B94F-505AEAE150F0
Your ads even talks about filtering with segments 🤷🏻‍♂️

@tsteur
Copy link
Member

tsteur commented Dec 18, 2019

You can filter reports through custom reports and through our API filters but in that it won't work indeed.

You can restore the old behaviour immediately by setting enable_segments_cache = 0 in your config/config.ini.php see my comment in #15163 (comment) We've added this setting in case someone really wants that old behaviour instead of just removing the old way altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered For when a question was asked and we referred to forum or answered it.
Projects
None yet
Development

No branches or pull requests

4 participants