Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable range select until overlay is fully loaded. #15162

Merged
merged 2 commits into from Nov 18, 2019
Merged

Disable range select until overlay is fully loaded. #15162

merged 2 commits into from Nov 18, 2019

Conversation

diosmosis
Copy link
Member

Fixes #14835

@diosmosis diosmosis added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Nov 15, 2019
@diosmosis diosmosis added this to the 3.13.0 milestone Nov 15, 2019
@sgiehl
Copy link
Member

sgiehl commented Nov 16, 2019

If the iframe origin can't be loaded there might still be a javascript error in Piwik_Overlay.js line 148:
Uncaught TypeError: Cannot read property '0' of null
Should be simple to fix, but not sure if it's worth. Otherwise looks good.

@diosmosis
Copy link
Member Author

@sgiehl should be fixed. will merge if build passes

@diosmosis diosmosis merged commit 6541514 into 3.x-dev Nov 18, 2019
@diosmosis diosmosis deleted the 14835 branch November 18, 2019 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.13.0
Development

Successfully merging this pull request may close these issues.

Page Overlay - JavaScript Error - TypeError: location.match(...) is null
2 participants
@diosmosis @sgiehl