@jmumby opened this Issue on November 13th 2019

Currently the "Powered by Matomo" logo is using an absolute path. This becomes an issue when used in an intranet and internet as the domain could be an ip address.

Change:

<img src="https://example.innocraft.cloud/plugins/Morpheus/images/logo.svg?matomo" tabindex="3" alt="Matomo" class="default-piwik-logo">

to

<img src="/plugins/Morpheus/images/logo.svg?matomo" tabindex="3" alt="Matomo" class="default-piwik-logo">

@sgiehl commented on November 16th 2019 Member

using an absolute path might make problems when Matomo is installed in a subdirectory

@mattab commented on January 21st 2020 Member

This becomes an issue when used in an intranet and internet as the domain could be an ip address.

Do you have more information on this possible problem @jmumby ? is it possible to reproduce this issue?

@jmumby commented on January 21st 2020

At the point of raising the issue the image appeared to use an absolute path. In this case if the same Matomo is used outside of an intranet where it is accessed via ip the image is broken.

For example, a user configures their Matomo on an intranet and is access via ip the image address could be:

<img src="https://192.168.1.1/plugins/Morpheus/images/logo.svg?matomo" tabindex="3" alt="Matomo" class="default-piwik-logo">

when being accessed externally the private address is not accessible.

@Findus23 commented on January 21st 2020 Member

I think (but am not sure) that replacing this with a relative path would only mask the issue in one place instead of fixing it (by (somehow?) fixing Matomo to show the right URL. Because there are places where such URLs are generated where relative URLs aren't possible (e.g. images in E-Mails)

Powered by GitHub Issue Mirror