Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the logo src to a relative path #15157

Closed
jmumby opened this issue Nov 13, 2019 · 5 comments
Closed

Change the logo src to a relative path #15157

jmumby opened this issue Nov 13, 2019 · 5 comments
Labels
Waiting for user feedback Indicates the Matomo team is waiting for feedback from the author or other users. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.

Comments

@jmumby
Copy link

jmumby commented Nov 13, 2019

Currently the "Powered by Matomo" logo is using an absolute path. This becomes an issue when used in an intranet and internet as the domain could be an ip address.

Change:

<img src="https://example.innocraft.cloud/plugins/Morpheus/images/logo.svg?matomo" tabindex="3" alt="Matomo" class="default-piwik-logo">

to

<img src="/plugins/Morpheus/images/logo.svg?matomo" tabindex="3" alt="Matomo" class="default-piwik-logo">

@sgiehl
Copy link
Member

sgiehl commented Nov 16, 2019

using an absolute path might make problems when Matomo is installed in a subdirectory

@mattab
Copy link
Member

mattab commented Jan 21, 2020

This becomes an issue when used in an intranet and internet as the domain could be an ip address.

Do you have more information on this possible problem @jmumby ? is it possible to reproduce this issue?

@mattab mattab added the Waiting for user feedback Indicates the Matomo team is waiting for feedback from the author or other users. label Jan 21, 2020
@jmumby
Copy link
Author

jmumby commented Jan 21, 2020

At the point of raising the issue the image appeared to use an absolute path. In this case if the same Matomo is used outside of an intranet where it is accessed via ip the image is broken.

For example, a user configures their Matomo on an intranet and is access via ip the image address could be:

<img src="https://192.168.1.1/plugins/Morpheus/images/logo.svg?matomo" tabindex="3" alt="Matomo" class="default-piwik-logo">

when being accessed externally the private address is not accessible.

@Findus23
Copy link
Member

I think (but am not sure) that replacing this with a relative path would only mask the issue in one place instead of fixing it (by (somehow?) fixing Matomo to show the right URL. Because there are places where such URLs are generated where relative URLs aren't possible (e.g. images in E-Mails)

@Findus23
Copy link
Member

I think the more general issue (Matomo generating URLs that are only valid in some contexts) should be solved instead: #14583

@Findus23 Findus23 added the wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it. label May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Waiting for user feedback Indicates the Matomo team is waiting for feedback from the author or other users. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Development

No branches or pull requests

4 participants