New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only add site to list of sites to reprocess if only date being processed is today. #15154
Conversation
@diosmosis can you have a look at the tests eg https://travis-ci.org/matomo-org/matomo/jobs/611159119?utm_medium=notification&utm_source=github_status ? |
@diosmosis I'm not sure this works as expected. I've been looking through the code for quite a while and been testing a few times and it seems like it's not reprocessing the data for today now. Like here... What I did was tracking a request... then archive the data ( |
|| $firstArchiveValue == ArchiveWriter::DONE_OK_TEMPORARY | ||
) { | ||
// if there is more than one archive, the older invalidated ones can be deleted | ||
if ($countOfArchives > 1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change is definitely good to have I would say and should fix the deletion of a lot of archives 👍
It was working for me when I tested it last... I'll try and test it again. |
@tsteur I was able to get it to work after a while after realizing visitorgenerator sets forced datetimes. It was setting the value to maybe an hour or so in the past, but the last successful archive run was from ~10s ago when I ran it. When I removed the setForceVisitDateTime() method call in VisitorGenerator it started working. After that I noticed one other issue, if you run multiple core:archives too quickly, it will skip archiving because not enough time has passed: Notice it says |
@diosmosis I had tested it with a simple tracking request. Archive. Send a basic tracking request through a website using JS tracking. Triggered archiving again. I had set the interval between archives from 900s to 1s so that shouldn't have been an issue. Could you maybe double check? |
@tsteur tested again, it works for me: initial visit count in log_visit: core archive after setting archive TTL to 1 (w/ a |
@tsteur if you could tell me what the reason for the site being skipped is, that might help. |
@diosmosis sorry it works now indeed. Not sure why it didn't before. LGTM 👍 |
@tsteur I hope it was just a failure to track or something that caused it to fail for you, because if it was the code at fault then it would probably be a timezone issue or something... |
Quick fix for #15086 ... and fix for archive purging logic now that today dates are invalidated and temporary archives do not exist.
Fixes #15086
Fixes #10439