Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update composer dependencies #15153

Merged
merged 3 commits into from Nov 15, 2019
Merged

Update composer dependencies #15153

merged 3 commits into from Nov 15, 2019

Conversation

diosmosis
Copy link
Member

@diosmosis diosmosis commented Nov 12, 2019 •
edited

Refs #14821

Includes:

  • update of tcpdf w/ php 7.4 fixes
  • update to branch of matomo-org/sparkline (fork of davaxi/sparkline) w/ @Findus23 's php 7.4 fix

@diosmosis diosmosis added the Needs Review PRs that need a code review label Nov 12, 2019
@diosmosis diosmosis added this to the 3.13.0 milestone Nov 12, 2019
@diosmosis diosmosis added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Nov 12, 2019
@sgiehl
Copy link
Member

sgiehl commented Nov 13, 2019

Is the failing system pdf test related to the tcpdf update?

@diosmosis
Copy link
Member Author

@sgiehl looks like it, i checked one of the PDFs and it appears identical to the expected.

@tsteur tsteur merged commit b3837f1 into 3.x-dev Nov 15, 2019
@tsteur tsteur deleted the update-composer branch November 15, 2019 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.13.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diosmosis @sgiehl @tsteur