Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore SSL errors in UI tests #15148

Merged
merged 1 commit into from Nov 12, 2019
Merged

Ignore SSL errors in UI tests #15148

merged 1 commit into from Nov 12, 2019

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Nov 12, 2019

Most of our UI tests are running on http but sometimes some actions may require HTTPS and redirect to HTTPS automatically.

I had this issue locally and got Error: net::ERR_CERT_AUTHORITY_INVALID at http://example.com/tests/PHPUnit/proxy/?idSite=1&period=day&date=2010-01-03&module=MobileMessaging&action=inde

I reckon there shouldn't be a down side to ignoring SSL errors in our tests?

Most of our UI tests are running on http but sometimes some actions may require HTTPS and redirect to HTTPS automatically. 

I had this issue locally and got ` Error: net::ERR_CERT_AUTHORITY_INVALID at http://example.com/tests/PHPUnit/proxy/?idSite=1&period=day&date=2010-01-03&module=MobileMessaging&action=inde`

I reckon there shouldn't be a down side to ignoring SSL errors in our tests?
@tsteur tsteur added the Needs Review PRs that need a code review label Nov 12, 2019
@tsteur tsteur added this to the 3.13.0 milestone Nov 12, 2019
@diosmosis diosmosis merged commit e6c9ed6 into 3.x-dev Nov 12, 2019
@diosmosis diosmosis deleted the uitests_sslerror branch November 12, 2019 02:40
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants