Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure missing GD extension doesn't break some features #15141

Merged
merged 1 commit into from Jan 26, 2020
Merged

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 10, 2019

Those small changes at least prevent the row evolution popover to only show the GD error. Instead only the sparklines will be shown as broken images. Guess that at least improves the behavior.

Not sure if that's enough to fix the referenced issue, or if we some-when try to find a way to show sparklines even without GD 🤷‍♂️

refs #15112

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Nov 10, 2019
@tsteur tsteur added this to the 4.0.0 milestone Nov 10, 2019
@tsteur tsteur changed the base branch from 3.x-dev to 4.x-dev January 14, 2020 03:58
@tsteur tsteur merged commit e8334d2 into 4.x-dev Jan 26, 2020
@tsteur tsteur deleted the ignoregderror branch January 26, 2020 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants