Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to a helpful FAQ in the error message "Oops, there was a problem during the request." #15135

Closed
mattab opened this issue Nov 8, 2019 · 4 comments · Fixed by #17900
Closed

Link to a helpful FAQ in the error message "Oops, there was a problem during the request." #15135

mattab opened this issue Nov 8, 2019 · 4 comments · Fixed by #17900
Assignees
@geekdenz
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Milestone
4.5.0

Comments

@mattab
Copy link
Member

mattab commented Nov 8, 2019 •
edited

Often Matomo users who haven't yet setup Cron + Disable browser trigger archiving, index

It would be great to link from this message to the FAQ that explains this issue: https://matomo.org/faq/troubleshooting/faq_19489/

Maybe with append a text like <a href='https://matomo.org/faq/troubleshooting/faq_19489/'>See the steps to resolve this issue in the FAQ</a>..

Note:

  • we don't want this extra text to be added on cloud. maybe we could link to the FAQ only when enable_general_settings_admin=1 or enable_plugins_admin=1
  • we will soon improve the FAQ at https://matomo.org/faq/troubleshooting/faq_19489/ and make it more clear / better
@mattab mattab added the c: Usability For issues that let users achieve a defined goal more effectively or efficiently. label Nov 8, 2019
@mattab mattab added this to the 4.2.0 milestone Jan 21, 2020
@tsteur tsteur added the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label Jul 22, 2021
@geekdenz
Copy link
Contributor

There seems to be something already here:

https://github.com/matomo-org/matomo/blob/4.x-dev/plugins/MultiSites/angularjs/dashboard/dashboard.directive.html#L61-L70

Also, I have trouble reproducing this error. Could you give me an example URL fragment?

@tsteur
Copy link
Member

tsteur commented Aug 16, 2021

@geekdenz

you can apply below patch and then go to Behavior -> Page URLs in the reporting menu. It will show the error. There are few other places where this error message is shown but I think that's maybe the most important one @mattab ?

diff --git a/plugins/Actions/Reports/GetPageUrls.php b/plugins/Actions/Reports/GetPageUrls.php
index 794848a8a5..b93ba48022 100644
--- a/plugins/Actions/Reports/GetPageUrls.php
+++ b/plugins/Actions/Reports/GetPageUrls.php
@@ -75,7 +75,7 @@ class GetPageUrls extends Base
         if (version_compare(DbHelper::getInstallVersion(),'4.0.0-b1', '<')) {
             $view->config->columns_to_display[] = 'avg_time_generation';
         }
-
+throw new \Exception('foo');
         $this->addPageDisplayProperties($view);
         $this->addBaseDisplayProperties($view);

geekdenz pushed a commit that referenced this issue Aug 18, 2021
show users more informative information on error
b7c69ec 
fixes #15135
@geekdenz geekdenz mentioned this issue Aug 18, 2021
Merged
11 tasks
geekdenz pushed a commit that referenced this issue Aug 19, 2021
add rel="noreferrer noopener" #15135
d57bb87
@geekdenz geekdenz modified the milestones: 4.6.0, 4.5.0 Aug 20, 2021
@geekdenz
Copy link
Contributor

There are 2 FAQ links now. The one you suggested above, @mattab and an old one:

matomo/lang/en.json

Line 170 in 850e1d7

"ErrorRequestFaqLink": "See the steps to resolve this issue in the FAQ.",

matomo/lang/en.json

Line 223 in 850e1d7

"Faq": "FAQ",

Is this what we want?

@tsteur
Copy link
Member

tsteur commented Aug 22, 2021

@geekdenz I'm not quite sure to which file/place you refer this to?

If it's about the one you mentioned in chat then we wouldn't show it twice
image

geekdenz pushed a commit that referenced this issue Aug 23, 2021
privatise variables
c79f211 
contributing to View::showMoreFaqInfo #15135
geekdenz pushed a commit that referenced this issue Aug 23, 2021
add message to recommended directories #15135
9a41b7a
geekdenz pushed a commit that referenced this issue Sep 4, 2021
@sgiehl
show users more informative information on error (#17900)
5d5e630 
* show users more informative information on error

fixes #15135

* add rel="noreferrer noopener" #15135

* show faq section only outside of cloud #15036

* privatise variables

contributing to View::showMoreFaqInfo #15135

Co-authored-by: Stefan Giehl <stefan@matomo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geekdenz geekdenz

Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Milestone
4.5.0
Development

Successfully merging a pull request may close this issue.

show users more informative information on error matomo-org/matomo
3 participants
@tsteur @mattab @geekdenz