Fix header alignment for multi-dimension reports #15134
Conversation
|
That kind of breaks the scrolling if the table doesn't have enough space as all |
|
Good point @sgiehl, have added CSS to ensure only the leftmost column will be made sticky. |
| left: 0; | ||
| z-index: 1; | ||
| background-clip: padding-box; | ||
|
|
||
| &:first-child { |
There was a problem hiding this comment.
@katebutler I reckon this overwrites https://github.com/matomo-org/matomo/pull/15129/files#diff-8b20fa1b843d28bf8988e7c3c93a54b2R661 and breaks the other feature?
Could we maybe simply add a new class to those column headers that does a textalign:left ? This should reduce the risk of breaking things
|
@katebutler can you update below screenshot which seems maybe due to this change and then merge? Thanks https://builds-artifacts.matomo.org/matomo-org/matomo/3.x-dev/37165/Comparison_subtables_loaded.png |
|
@katebutler any chance this related to your change? https://builds-artifacts.matomo.org/matomo-org/matomo/3.x-dev/37231/UsersManager_permissions_bulk_access_set.png |
|
I wouldn't have thought so - it looks OK in my browser and the heading that's disappeared doesn't have the |
Fixes #15118