Show 'new' metrics on visitor engagement report/sparklines #15128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katebutler
added
the
Pull Request WIP
katebutler
added
Needs Review
tsteur
requested changes
Nov 18, 2019
added 4 commits
November 21, 2019 10:01
# Conflicts: # plugins/Ecommerce/tests/System/expected/test_ecommerceOrderWithItems_schedrep_in_pdf_tables_only__ScheduledReports.generateReport_week.original.pdf # tests/PHPUnit/System/expected/test_DataComparisonTest_multipleMultiPeriods__VisitFrequency.get_day.xml # tests/PHPUnit/System/expected/test_DataComparisonTest_multipleSites_multipleCompare__VisitFrequency.get_month.xml # tests/PHPUnit/System/expected/test_TwoVisitors_twoWebsites_differentDays_schedrep_in_pdf_tables_only__ScheduledReports.generateReport_month.original.pdf
added 7 commits
November 28, 2019 15:05
# Conflicts: # tests/PHPUnit/System/expected/test_BackwardsCompatibility1XTest__VisitFrequency.get_range.xml # tests/PHPUnit/System/expected/test_BackwardsCompatibility1XTest__VisitFrequency.get_year.xml # tests/PHPUnit/System/expected/test_BackwardsCompatibility1XTest_multipleOldNew__VisitFrequency.get_month.xml
… new or returning ones (unable to trigger this as the evolution graph doesn't call the method at all in this case); ensure that only the columns requested will be returned
…tests to check that correct columns are returned
|
@katebutler looking at the tests there seem to be heaps of them failing? |
|
@katebutler can you update the ecommerce tests as discussed last Thursday or Friday? Then we can merge |
diosmosis
reviewed
Dec 17, 2019
| $columns = Piwik::getArrayFromApiParameter($columns); | ||
|
|
||
| /** @var \Piwik\DataTable\DataTableInterface $resultSet */ | ||
| $resultSet = new DataTable(); |
There was a problem hiding this comment.
FYI, this needs to be new Simple() otherwise the XML output will have an extra <row> element.
diosmosis
pushed a commit
that referenced
this pull request
Dec 18, 2019
jonasgrilleres
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 22, 2020
jonasgrilleres
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 22, 2020
* Switch VisitFrequency to use Simple datatable, restore constant in Goals API for BC * Update system test files
jbuget
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 26, 2020
jbuget
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 26, 2020
* Switch VisitFrequency to use Simple datatable, restore constant in Goals API for BC * Update system test files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #539