@MichaelHeerklotz opened this Pull Request on November 6th 2019 Contributor

Adds support for up to 4 fields in the multipairfield config template.
Needed for another pull requests for Tag Manager (support for Custom Variables https://github.com/matomo-org/tag-manager/pull/201).

Maybe the changes in "plugins/CorePluginsAdmin/angularjs/form-field/field-multituple.html" are not required? I am not 100% sure.

@tsteur commented on November 6th 2019 Member

Looks good in general @MichaelHeerklotz but haven't tested it yet. Could you maybe add an example to Morpheus/templates/demo.twig so it will be rendered in a screenshot test?

@MichaelHeerklotz commented on November 11th 2019 Contributor

@tsteur Thank you for your feedback! I have fixed/updated the styles a bit and updated the demo template.

@tsteur commented on November 11th 2019 Member

Change looks good 👍 any chance you could include this UI change https://builds-artifacts.matomo.org/matomo-org/matomo/3.x-dev/36950/Morpheus_load.png ? (screenshot update looks expected)

Powered by GitHub Issue Mirror