Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves issue #15120 #15122

Closed

Conversation

peter279k
Copy link
Contributor

@sgiehl
Copy link
Member

sgiehl commented Nov 6, 2019

Thanks for the PR. We also need to update the composer.lock in this case.

@peter279k
Copy link
Contributor Author

Hi @sgiehl, thanks for your reply.

My question is: How to update the composer.lock file?

Using the php-5.5.x to execute composer and using update command to update cached dependency information on composer.lock file?

@sgiehl
Copy link
Member

sgiehl commented Nov 10, 2019

actually you would need to let composer update the composer.json & composer.lock by executing those commands (without your changes). The PHP version you are running doesn't matter as long as it satisfies the requirements (>5.5.x):

composer remove facebook/xhprof
composer require --dev lot/xhprof dev-master

After that I guess the additional repository entry for facebook/xhprof can be removed manually from composer.json

@peter279k
Copy link
Contributor Author

Hi @sgiehl, I've update the composer.lock file and please review this PR again.

Thanks.

composer.json Show resolved Hide resolved
@sgiehl
Copy link
Member

sgiehl commented Feb 4, 2020

@peter279k I'll close this one, as we won't change that for 3.x-dev branch anymore. Would you mind recreating the PR against 4.x-dev branch, if it still makes sense? Thx!

@sgiehl sgiehl closed this Feb 4, 2020
@peter279k
Copy link
Contributor Author

@sgiehl, thanks for your reply. I will recreating one PR for 4.x-dev branch :).

@peter279k peter279k deleted the issue_#15120 branch February 4, 2020 08:25
@peter279k peter279k mentioned this pull request Feb 4, 2020
@mattab mattab added this to the Backlog (Help wanted) milestone Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants