Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Considering the facebook/xhprof package is deprecated #15120

Closed
peter279k opened this issue Nov 6, 2019 · 3 comments
Closed

Considering the facebook/xhprof package is deprecated #15120

peter279k opened this issue Nov 6, 2019 · 3 comments
Labels
wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Milestone
4.0.0

Comments

@peter279k
Copy link
Contributor

As title. Firstly, we look at the require-dev block on composer.json, we can notice that it requires the facebook/xhprof.
After visiting this package page via the Packagist link, I aware that following deprecated warning message:

This package is abandoned and no longer maintained. The author suggests using the lox/xhprof package instead.

And I think we should also use the new package to replace the facebook/xhprof :).
@tsteur
Copy link
Member

tsteur commented Nov 6, 2019

👍 totally. Feel free to create a PR 👍

@tsteur
Copy link
Member

tsteur commented Nov 6, 2019

Our profiler supports for example tideways profiler (not the remove service but the php extension)

peter279k added a commit to open-source-contributions/matomo that referenced this issue Nov 6, 2019
@peter279k
Resolves issue matomo-org#15120
a9cfc27
@peter279k peter279k mentioned this issue Nov 6, 2019
Closed
peter279k added a commit to open-source-contributions/matomo that referenced this issue Nov 11, 2019
@peter279k
Resolves issue matomo-org#15120
aa60c6f
peter279k added a commit to open-source-contributions/matomo that referenced this issue Nov 11, 2019
@peter279k
Resolves issue matomo-org#15120
13b587e
@mattab mattab added this to the 4.0.0 milestone Jan 21, 2020
@mattab mattab added the c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. label Jan 21, 2020
@tsteur
Copy link
Member

tsteur commented Jan 24, 2020

Actually, closing this for now as xhprof was updated just last month.

@tsteur tsteur closed this as completed Jan 24, 2020
@tsteur tsteur added wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it. and removed c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. labels Jan 24, 2020
peter279k added a commit to open-source-contributions/matomo that referenced this issue Feb 4, 2020
@peter279k
Resolves issue matomo-org#15120
74378b2
peter279k added a commit to open-source-contributions/matomo that referenced this issue Feb 4, 2020
@peter279k
Resolves issue matomo-org#15120
d00e1e7
sgiehl pushed a commit that referenced this issue Feb 4, 2020
@peter279k
Resolves issue #15120 (#15512)
1c87257
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
3 participants
@tsteur @mattab @peter279k