New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor cron archiving for simplicity #15117
Comments
Basic implementation would be:
thoughts @tsteur ? |
@diosmosis Wondering... When we create a When we start an archive
When a tracking request comes in:
Ideally, when an archive from 50 days ago is invalidated, the archiver be ideally smart enough to not launch with It's probably not quite related to what you mentioned though. The logic sounds good though that you suggested. It's basically like a "queue" what needs to be archived and it's all based on invalidation. 👍 |
I think I understand what you're saying, basically, right after ArchiveWriter::finalizeArchive(), delete old archives, right? This could work and I think it is related to this, it would make it harder for an old getInvalidatedArchives() data cache to cause problems, but I suppose we wouldn't be able to get rid of ArchivePurger, since we'd still need to support the command to purge... |
This should be easily do-able and I think we have to do it this way to do this refactor. lastN would just be wasteful. |
Now that we invalidate archives when a visit is tracked, we have a couple more opportunities for refactoring:
This should allow splitting archiving of large websites across separate processes and simplify the code quite a bit.
Some things to keep in mind:
The text was updated successfully, but these errors were encountered: