Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the link to upload a new plugin when enable_plugin_upload=1 #15116

Merged
merged 1 commit into from Nov 7, 2019

Conversation

mattab
Copy link
Member

@mattab mattab commented Nov 5, 2019

Reproduce:

  • Disable Marketplace
  • Enable enable_plugin_upload=1
  • Got: no link to upload the plugin in the top of "Plugins" page.
  • Expected to see the link to upload the plugin

Note: with this patch, if Marketplace is disabled and enable_plugin_upload=1 then users will see a link to the Marketplace as well as the zip upload link. When clicked it says "The plugin Marketplace is not enabled. You can activate the plugin on Settings > Plugins page in Matomo." which is fine imho.

Reproduce:
* Disable Marketplace
* Enable `enable_plugin_upload=1`
* Got: no link to upload the plugin in the top of "Plugins" page.
* Expected to see the link to upload the plugin

Note: with this patch, if Marketplace is disabled and enable_plugin_upload=1 then users will see a link to the Marketplace as well as the zip upload link. When clicked it says "The plugin Marketplace is not enabled. You can activate the plugin on Settings > Plugins page in Matomo." which is fine imho.
@mattab mattab added the Needs Review PRs that need a code review label Nov 5, 2019
@mattab mattab added this to the 3.13.0 milestone Nov 5, 2019
@diosmosis diosmosis merged commit c4fc47c into 3.x-dev Nov 7, 2019
@diosmosis diosmosis deleted the upload_zip branch November 7, 2019 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants