Better detection of a succesfull start of a session #15114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differentiate between errors and warnings in session error handler and only assume session was not started if there was an error triggered. It should not throw an exception if there was only a notice or a warning.
tsteur
commented
Nov 5, 2019
| @@ -479,14 +479,14 @@ public static function start($options = false) | |||
| restore_error_handler(); | |||
| } | |||
|
|
|||
| if (!$startedCleanly || Zend_Session_Exception::$sessionStartError != null) { | |||
| if (!$startedCleanly || !empty(Zend_Session_Exception::$sessionStartError)) { | |||
There was a problem hiding this comment.
ideally we would even only go into that logic if !$startedCleanly and not look at Zend_Session_Exception::$sessionStartError at all but I reckon we could still change that later.
tsteur
commented
Nov 5, 2019
| if (!isset(self::$sessionStartError)) { | ||
| self::$sessionStartError = ''; | ||
| $message = $errfile . '(Line:' . $errline . '): Error #' . $errno . ' ' . $errstr; | ||
| if (E_ERROR === $errno || E_CORE_ERROR === $errno || E_COMPILE_ERROR === $errno) { |
There was a problem hiding this comment.
only trigger a session start exception when one of these 3 errors occur. Those 3 should be enough and no need to handle recoverable error etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differentiate between errors and warnings in session error handler and only assume session was not started if there was an error triggered. It should not throw an exception if there was only a notice or a warning.
Needed for WordPress. Eg there a caching plugin was trying to delete some cache after we executed a DB query, and did cache deletion on the file system triggered a warning. Then Zend_Session assumed the session was not started correctly even though it was and the warning was not related to session_start at all