Prevent test cookie from being created when cookies are disabled #15107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
not-in-changelog
|
Can a tracker JS test be added for this? |
|
@diosmosis I don't think it's really possible since this would need to be tested kind of "on load" I think |
diosmosis
force-pushed
the
15000
branch
2 times, most recently
from
1670e18
to
afcb7ab
Compare
|
The cookie is still set! |
|
@dirk-graetz make sure you are on the latest version of Matomo. Then I recommend you clear all cookies and reload the page. The testcookie should have a very old expiry date meaning it's set but invalidated at the same time (aka deleted). It appearing in the list, depending on the browser, is unavoidable. If you were to remove the tracking code afterwards for a test, you would notice the cookie is gone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #15000