Fix Insight visualization layout #15102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
the
Regression
sgiehl
force-pushed
the
insightslayout
branch
from
ce4f171
to
f0d8370
Compare
tsteur
reviewed
Nov 4, 2019
| @@ -60,9 +60,6 @@ | |||
| $('td.label', domElem).width(parseInt(width * 0.50, 10)); | |||
| } | |||
|
|
|||
| var showScrollbarIfMoreThanThisPxOverlap = 32; | |||
There was a problem hiding this comment.
@sgiehl is removing this maybe causing https://builds-artifacts.matomo.org/matomo-org/matomo/3.x-dev/36806/UIIntegrationTest_dashboard2.png ?
There was a problem hiding this comment.
not sure. need to investigate that
There was a problem hiding this comment.
should be fixed with the last commit
sgiehl
force-pushed
the
insightslayout
branch
from
f0d8370
to
21a27fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The layout of the insight visualization is currently kind of broken, due to various changes. See for example https://builds-artifacts.matomo.org/matomo-org/plugin-CustomDimensions/fixbuild/772/CustomDimensions_report_action_insights.png