Invert change comparison when displaying percents in the UI … #15098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…extra _change_from metric to support API calculation of from change percent when there are more than two periods.
diosmosis
added
c: Design / UI
diosmosis
removed
the
c: Design / UI
|
@diosmosis is this UI change expected? https://builds-artifacts.matomo.org/matomo-org/matomo/comparison-percents-ui/36774/Comparison_totals_tooltip.png
do we still expect the first row to show the BTW there's also at least one system test failing. Code looks good otherwise |
|
You're comparing 12-17 w/ 1-31, so it's showing the change from 1-31 => 12-17, ie, jan 12-17 is 42% lower when compared with jan 1-31, so it's correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and add extra _change_from metric to support API calculation of from change percent when there are more than two periods.
Changes:
_change_frommetrics to the output. This allows users to get the new metrics that are displayed through the API when any number of periods are compared.