Remove the SiteSpecificUserAgentExcludeEnabled setting #15089
Conversation
…ter removal of isSiteSpecificExcludedUserAgentsEnabled
katebutler
added
the
Pull Request WIP
|
@katebutler as discussed by good to add an entry to the changelog under the deprecations section that we will remove the API method in Matomo 4 and we would also add a test that the deprecated method will actually be removed then. |
# Conflicts: # tests/UI/expected-screenshots/UIIntegrationTest_api_listing.png
katebutler
added
Needs Review
| @@ -60,7 +60,6 @@ class API extends \Piwik\Plugin\API | |||
| const OPTION_SEARCH_KEYWORD_QUERY_PARAMETERS_GLOBAL = 'SitesManager_SearchKeywordParameters'; | |||
| const OPTION_SEARCH_CATEGORY_QUERY_PARAMETERS_GLOBAL = 'SitesManager_SearchCategoryParameters'; | |||
| const OPTION_EXCLUDED_USER_AGENTS_GLOBAL = 'SitesManager_ExcludedUserAgentsGlobal'; | |||
| const OPTION_SITE_SPECIFIC_USER_AGENT_EXCLUDE_ENABLE = 'SitesManager_EnableSiteSpecificUserAgentExclude'; | |||
There was a problem hiding this comment.
Could do as it's easy. Not 100% needed though.
|
The expected file changes are all related to the change in the |
Then I guess I don't understand why that should change the test fixtures. Before the OneVisitorTwoVisits might have set a site specific useragent exclude, but disabled the site specific exclude globally in that case before. So it actually shouldn't have had any effect on the test fixture. So removing that part should also not have any effect. Or did I get anything wrong? 🤔 |
|
@sgiehl I haven't tested it yet but code looks generally good. I was expecting the change eg because of https://github.com/matomo-org/matomo/pull/15089/files#diff-9cceb103a81e46f4388517c3b4c33427L245 maybe? |
Fixes #14880