@katebutler opened this Pull Request on October 31st 2019 Member

Fixes #14880

@tsteur commented on October 31st 2019 Member

@katebutler as discussed by good to add an entry to the changelog under the deprecations section that we will remove the API method in Matomo 4 and we would also add a test that the deprecated method will actually be removed then.

@katebutler commented on November 13th 2019 Member

The expected file changes are all related to the change in the OneVisitorTwoVisits fixture, which was using the site-specific useragent exclude setting.

@sgiehl commented on November 16th 2019 Member

The expected file changes are all related to the change in the OneVisitorTwoVisits fixture, which was using the site-specific useragent exclude setting.

Then I guess I don't understand why that should change the test fixtures. Before the OneVisitorTwoVisits might have set a site specific useragent exclude, but disabled the site specific exclude globally in that case before. So it actually shouldn't have had any effect on the test fixture. So removing that part should also not have any effect. Or did I get anything wrong? :thinking:

@tsteur commented on November 17th 2019 Member

@sgiehl I haven't tested it yet but code looks generally good. I was expecting the change eg because of https://github.com/matomo-org/matomo/pull/15089/files#diff-9cceb103a81e46f4388517c3b4c33427L245 maybe?

This Pull Request was closed on November 28th 2019
Powered by GitHub Issue Mirror