When checking if a segment archive table exists, try to read data from an actual column #15077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m an actual column I'm trying to update WP-Matomo to 3.12.0 and noticed mysqli is not triggering an error when doing a `select 1`. At least in WordPress. Not sure it's an issue with our mysqli implementation as well but might be (haven't seen anything in tests though)
tsteur
added
the
Pull Request WIP
|
Shouldn't be needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to update WP-Matomo to 3.12.0 and noticed mysqli is not triggering an error when doing a
select 1. At least in WordPress. Not sure it's an issue with our mysqli implementation as well but might be (haven't seen anything in tests though)