New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix label truncation calculation #15068
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
not-in-changelog
For issues or pull requests that should not be included in our release changelog on matomo.org.
Needs Review
PRs that need a code review
Regression
Indicates a feature used to work in a certain way but it no longer does even though it should.
labels
Oct 28, 2019
@sgiehl there's now a gap on the right, eg see https://builds-artifacts.matomo.org/matomo-org/matomo/3.x-dev/36697/UIIntegrationTest_actions_content_name_piece.png |
sgiehl
force-pushed
the
fixlabeltruncate
branch
from
October 28, 2019 20:55
d0c1a49
to
e94eaca
Compare
sgiehl
force-pushed
the
fixlabeltruncate
branch
from
October 28, 2019 22:05
e94eaca
to
a04c978
Compare
Thank you for fixing @sgiehl very appreciated 🎉 |
sgiehl
added a commit
that referenced
this pull request
Nov 1, 2019
sgiehl
added a commit
that referenced
this pull request
Nov 2, 2019
sgiehl
added a commit
that referenced
this pull request
Nov 2, 2019
sgiehl
added a commit
that referenced
this pull request
Nov 2, 2019
sgiehl
added a commit
that referenced
this pull request
Nov 2, 2019
sgiehl
added a commit
that referenced
this pull request
Nov 2, 2019
sgiehl
added a commit
that referenced
this pull request
Nov 2, 2019
diosmosis
pushed a commit
that referenced
this pull request
Nov 3, 2019
* Fix various regressions from #15068 * updates expected UI files
diosmosis
pushed a commit
that referenced
this pull request
Nov 6, 2019
* Fix label truncation calculation regrssion of #14365 * updates expected screenshots
diosmosis
pushed a commit
that referenced
this pull request
Nov 6, 2019
* Fix various regressions from #15068 * updates expected UI files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Needs Review
PRs that need a code review
not-in-changelog
For issues or pull requests that should not be included in our release changelog on matomo.org.
Regression
Indicates a feature used to work in a certain way but it no longer does even though it should.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not sure why the line was moved down in #14365. ping @diosmosis
regression of #14365
fixes #15053