Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix label truncation calculation #15068

Merged
merged 2 commits into from Oct 29, 2019
Merged

Fix label truncation calculation #15068

merged 2 commits into from Oct 29, 2019

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Oct 28, 2019

not sure why the line was moved down in #14365. ping @diosmosis

regression of #14365

fixes #15053

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Oct 28, 2019
@sgiehl sgiehl added this to the 3.12.0 milestone Oct 28, 2019
@tsteur
Copy link
Member

tsteur commented Oct 28, 2019

@mattab mattab merged commit 2edbd27 into 3.x-dev Oct 29, 2019
@mattab
Copy link
Member

mattab commented Oct 29, 2019

Thank you for fixing @sgiehl very appreciated 🎉

@mattab
Copy link
Member

mattab commented Oct 29, 2019

@sgiehl can confirm the white border as @tsteur reported is now visible. Be great to address this in another PR!

sgiehl added a commit that referenced this pull request Nov 1, 2019
@sgiehl sgiehl deleted the fixlabeltruncate branch November 1, 2019 11:49
sgiehl added a commit that referenced this pull request Nov 2, 2019
sgiehl added a commit that referenced this pull request Nov 2, 2019
sgiehl added a commit that referenced this pull request Nov 2, 2019
sgiehl added a commit that referenced this pull request Nov 2, 2019
sgiehl added a commit that referenced this pull request Nov 2, 2019
sgiehl added a commit that referenced this pull request Nov 2, 2019
diosmosis pushed a commit that referenced this pull request Nov 3, 2019
* Fix various regressions from #15068

* updates expected UI files
diosmosis pushed a commit that referenced this pull request Nov 6, 2019
* Fix label truncation calculation

regrssion of #14365

* updates expected screenshots
diosmosis pushed a commit that referenced this pull request Nov 6, 2019
* Fix various regressions from #15068

* updates expected UI files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page Title names are not truncated anymore
3 participants