Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid 'Trying to add two strings in DataTable\Row::sumRowArray' warning in SEO API #15066

Merged
merged 1 commit into from Nov 4, 2019

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Oct 28, 2019

When SEO.getRank is called with a filter_limit a warning is currently triggered, as a summary row is being built, causing errors in sumRowArray.

As a limit doesn't make much sense for that method at all, I decided to also deactivate the Limit filter, so all row are always returned.

fixes DEV-1803

@sgiehl sgiehl added the Needs Review PRs that need a code review label Oct 28, 2019
@sgiehl sgiehl added this to the 3.13.0 milestone Oct 28, 2019
@diosmosis diosmosis merged commit 4fc86a4 into 3.x-dev Nov 4, 2019
@diosmosis diosmosis deleted the seowarning branch November 4, 2019 00:45
diosmosis pushed a commit that referenced this pull request Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants