Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates device detector to 3.12.1 #15055

Merged
merged 4 commits into from Nov 4, 2019
Merged

Updates device detector to 3.12.1 #15055

merged 4 commits into from Nov 4, 2019

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Oct 24, 2019

ping @Findus23 the new device type smart speaker might need an icon

@Findus23
Copy link
Member

Is the material.io speaker icon okay?

image

@sgiehl
Copy link
Member Author

sgiehl commented Oct 24, 2019

should be ok for now. we can change it later again if needed

@Findus23
Copy link
Member

Added the icon. Can you please checkout the latest submodule and check if it works.

@sgiehl sgiehl force-pushed the ddup branch 2 times, most recently from fac55ef to 7673ac3 Compare October 26, 2019 08:37
@sgiehl sgiehl marked this pull request as ready for review October 26, 2019 21:37
@sgiehl sgiehl added this to the 3.12.0 milestone Oct 26, 2019
@sgiehl sgiehl added the Needs Review PRs that need a code review label Oct 26, 2019
@mattab mattab modified the milestones: 3.12.0, 3.13.0 Oct 29, 2019
@diosmosis diosmosis merged commit 22137c6 into 3.x-dev Nov 4, 2019
@diosmosis diosmosis deleted the ddup branch November 4, 2019 00:59
diosmosis pushed a commit that referenced this pull request Nov 6, 2019
* updates device detector to 3.12.1

* adds new device type smart speaker

* updates expected test files

* updates UI files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants