Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send queued requests slightly less often and have method to change interval #15048

Merged
merged 1 commit into from Nov 4, 2019
Merged

Send queued requests slightly less often and have method to change interval #15048

merged 1 commit into from Nov 4, 2019

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Oct 24, 2019

Eg instead of waiting for 1.75s we now wait for 2.5seconds. Since we're falling back to sendBeacon anyway there should be no risk in missing any information.

And there is a new method so plugins or users can change the interval.

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Oct 24, 2019
@tsteur tsteur added this to the 3.13.0 milestone Oct 24, 2019
sgiehl
sgiehl approved these changes Oct 28, 2019
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested, but code looks fine and tests are still passing 👍

@diosmosis diosmosis merged commit 7ba181b into 3.x-dev Nov 4, 2019
@diosmosis diosmosis deleted the requestQueueInterval branch November 4, 2019 00:49
diosmosis pushed a commit that referenced this pull request Nov 6, 2019
@tsteur @diosmosis
Send queued requests less often (#15048)
a532345
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.13.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tsteur @sgiehl @diosmosis