Don't sum row columns #15042
Closed
Don't sum row columns #15042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure what side effects this may have. Was first solving this in MediaAnayltics to prevent notices such as: > WARNING MediaAnalytics[2019-09-23 19:22:13 UTC] [3489 ...] Trying to add two strings in DataTable\Row::sumRowArray: https:/... + https://...) for column url in row # ['label' => -1, 'nb_plays' => 8, 'nb_unique_visitors_plays' => 3, 'nb_impressions' => 80, 'nb_unique_visitors_impressions' => 47, 'nb_finishes' => 5, 'sum_media_length' => 120, 'sum_time_watched' => 87, 'sum_time_to_play' => 10, 'sum_time_progress' => 84, 'nb_plays_with_tip' => 8, 'nb_plays_with_ml' => 8, 'sum_fullscreen_plays' => 0, 'url' => 'https://...'] [] [idsubtable = ]<br /> but then also noticed this problem in other plugins such as Funnels. Maybe that fixes it for all plugins considering `url` is a common column maybe in Matomo and it shouldn't be summable?
|
Actually, the url column should be metadata so it shouldn't be summed there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure what side effects this may have. Was first solving this in MediaAnayltics to prevent notices such as:
but then also noticed this problem in other plugins such as Funnels. Maybe that fixes it for all plugins considering
urlis a common column maybe in Matomo and it shouldn't be summable?