@tsteur opened this Pull Request on October 22nd 2019 Member

refs https://github.com/matomo-org/matomo/issues/15033
it might fix that issue

fixes a regression from https://github.com/matomo-org/matomo/pull/14996

When you have the Visits over time for example in the dashboard, view day period, select unique visitors, then select year period, it will then show visits metric instead of unique visitors because unique visitors is not available for year. The visits metric will not show any data though because it had the &columns=nb_unique_visitors param applied and the visits metric was never fetched. That's because in https://github.com/matomo-org/matomo/pull/14996 the metric was replaced after the dataTable was being requested. Trying to do this now before requesting dataTable too. Not sure what other regressions this could potentially introduce...

@tsteur commented on October 22nd 2019 Member

Tests are succeeding and user confirms it's working so merging the PR. @sgiehl if you could later maybe have a quick look at the PR be great

This Pull Request was closed on October 22nd 2019
Powered by GitHub Issue Mirror