Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide "AND segmented reports are pre-processed (faster, requires cron)" from the UI when enable_create_realtime_segments = 0 #15036

Closed
mattab opened this issue Oct 22, 2019 · 3 comments · Fixed by #17882
Closed

Hide "AND segmented reports are pre-processed (faster, requires cron)" from the UI when enable_create_realtime_segments = 0 #15036

mattab opened this issue Oct 22, 2019 · 3 comments · Fixed by #17882
Assignees
@geekdenz
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. Needs Review PRs that need a code review
Milestone
4.5.0

Comments

@mattab
Copy link
Member

mattab commented Oct 22, 2019

Currently the UI looks like this:
Screenshot from 2019-10-22 17-32-10

The last selector cannot be changed when enable_create_realtime_segments = 0

Because it provide no value in itself, it would be great to hide the text all together: "AND segmented reports are pre-processed (faster, requires cron)" from the UI when enable_create_realtime_segments = 0
@mattab mattab added the c: Usability For issues that let users achieve a defined goal more effectively or efficiently. label Oct 22, 2019
@mattab mattab added this to the 4.2.0 milestone Jan 21, 2020
@tsteur tsteur added the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label Jul 22, 2021
@tsteur
Copy link
Member

tsteur commented Jul 22, 2021 •
edited

We want to remove this part in that case because there is only one option available anyway.
image

@geekdenz geekdenz self-assigned this Aug 10, 2021
@geekdenz
Copy link
Contributor

I interpret this as:

We want to remove "SEGMENTED REPORTS ARE PRE-PROCESSED (FASTER, REQUIRES CRON)", replace it with "SEGMENTED REPORTS ARE PRE-PROCESSED", making it NOT bold and get rid of the dropdown.

Is this correct?

@tsteur
Copy link
Member

tsteur commented Aug 11, 2021

We could remove the entire part as in the screenshot in #15036 (comment)

we don't need to show it in non-bold.

geekdenz pushed a commit that referenced this issue Aug 13, 2021
hide segmented reports are pre-processed
6f90712 
when enable_create_realtime_segments = 0
fixes #15036
@geekdenz geekdenz mentioned this issue Aug 13, 2021
Merged
10 tasks
geekdenz pushed a commit that referenced this issue Aug 13, 2021
ensure static method because static call fixes #15036
0ebccc5
@geekdenz geekdenz added the Needs Review PRs that need a code review label Aug 15, 2021
geekdenz pushed a commit that referenced this issue Aug 16, 2021
refactor to use SegmentEditor::isCreateRealtimeSegmentsEnabled() #15036
2320d29
@geekdenz geekdenz modified the milestones: 4.6.0, 4.5.0 Aug 19, 2021
@geekdenz geekdenz added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Aug 19, 2021
geekdenz pushed a commit that referenced this issue Aug 20, 2021
show faq section only outside of cloud #15036
71839dd
geekdenz pushed a commit that referenced this issue Aug 20, 2021
show faq section only outside of cloud #15036
850e1d7
geekdenz pushed a commit that referenced this issue Aug 20, 2021
show faq section only outside of cloud #15036
55996c8
geekdenz pushed a commit that referenced this issue Aug 23, 2021
hide segmented reports are pre-processed
e906101 
when enable_create_realtime_segments = 0
fixes #15036
geekdenz pushed a commit that referenced this issue Aug 23, 2021
ensure static method because static call fixes #15036
5e63d08
geekdenz pushed a commit that referenced this issue Aug 23, 2021
refactor to use SegmentEditor::isCreateRealtimeSegmentsEnabled() #15036
10d8bd4
geekdenz pushed a commit that referenced this issue Aug 23, 2021
update ui test for hidden segmented report text #15036
e193c51
geekdenz pushed a commit that referenced this issue Aug 23, 2021
add expected screenshot for ui test #15036
9112777
justinvelluppillai pushed a commit that referenced this issue Aug 23, 2021
@justinvelluppillai
hide segmented reports are pre-processed
294175a 
when enable_create_realtime_segments = 0
fixes #15036
justinvelluppillai pushed a commit that referenced this issue Aug 23, 2021
@justinvelluppillai
ensure static method because static call fixes #15036
f7ceff0
justinvelluppillai pushed a commit that referenced this issue Aug 23, 2021
@justinvelluppillai
refactor to use SegmentEditor::isCreateRealtimeSegmentsEnabled() #15036
8368fa6
justinvelluppillai pushed a commit that referenced this issue Aug 23, 2021
@justinvelluppillai
update ui test for hidden segmented report text #15036
2207684
justinvelluppillai pushed a commit that referenced this issue Aug 23, 2021
@justinvelluppillai
add expected screenshot for ui test #15036
643c7d2
geekdenz pushed a commit that referenced this issue Aug 23, 2021
hide segmented reports are pre-processed
cebbb24 
when enable_create_realtime_segments = 0
fixes #15036
geekdenz pushed a commit that referenced this issue Aug 23, 2021
ensure static method because static call fixes #15036
0bb1e93
geekdenz pushed a commit that referenced this issue Aug 23, 2021
refactor to use SegmentEditor::isCreateRealtimeSegmentsEnabled() #15036
7995133
geekdenz pushed a commit that referenced this issue Aug 23, 2021
hide segmented reports are pre-processed
d13621b 
when enable_create_realtime_segments = 0
fixes #15036
geekdenz pushed a commit that referenced this issue Aug 23, 2021
ensure static method because static call fixes #15036
ea17198
geekdenz pushed a commit that referenced this issue Aug 23, 2021
update ui test for hidden segmented report text #15036
ad9107a
geekdenz pushed a commit that referenced this issue Aug 25, 2021
add ui-test screenshot #15036
709e268
geekdenz pushed a commit that referenced this issue Aug 25, 2021
wait for network #15036
2686354
geekdenz pushed a commit that referenced this issue Aug 26, 2021
download processed screenshot #15036
3aa1db6
sgiehl pushed a commit that referenced this issue Aug 26, 2021
hide segmented reports are pre-processed (#17882)
56ead71 
* hide segmented reports are pre-processed

when enable_create_realtime_segments = 0
fixes #15036

* ensure static method because static call fixes #15036

* refactor to use SegmentEditor::isCreateRealtimeSegmentsEnabled() #15036

* hide segmented reports are pre-processed

when enable_create_realtime_segments = 0
fixes #15036

* ensure static method because static call fixes #15036

* update ui test for hidden segmented report text #15036

* add ui-test screenshot #15036

* wait for network #15036

* download processed screenshot #15036
geekdenz pushed a commit that referenced this issue Sep 4, 2021
@sgiehl
show users more informative information on error (#17900)
5d5e630 
* show users more informative information on error

fixes #15135

* add rel="noreferrer noopener" #15135

* show faq section only outside of cloud #15036

* privatise variables

contributing to View::showMoreFaqInfo #15135

Co-authored-by: Stefan Giehl <stefan@matomo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geekdenz geekdenz

Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. Needs Review PRs that need a code review
Projects
None yet
Milestone
4.5.0
Development

Successfully merging a pull request may close this issue.

hide segmented reports are pre-processed matomo-org/matomo
3 participants
@tsteur @mattab @geekdenz