Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.12.0-rc1: No dashboard graph anymore? #15033

Closed
dertuxmalwieder opened this issue Oct 22, 2019 · 6 comments
Closed

3.12.0-rc1: No dashboard graph anymore? #15033

dertuxmalwieder opened this issue Oct 22, 2019 · 6 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone

Comments

@dertuxmalwieder
Copy link

When updating my Matomo installation from the last 3.12.0 beta version to 3.12.0-rc1, the graph of recent visitors in my dashboard stopped working:

HEgfZvJ

This does not mean that suddenly nobody cares about my website anymore. The graph on the Visitors page works:

ox8Gsct

So does the other visitors dashboard graph:

wjTlavF

I really prefer the "Graph der letzten Besuche" though. It is less roomy.

@tsteur
Copy link
Member

tsteur commented Oct 22, 2019

Only thing I can image is that it's related to 3.12.0-b7...3.12.0-rc1#diff-2c49596f288bc707bfda47f4b648bc57R241 but I can't reproduce it and it would be maybe only an issue if unique visitors was selected before. @sgiehl any thoughts?

@tsteur
Copy link
Member

tsteur commented Oct 22, 2019

@dertuxmalwieder does it work when you remove the widget and add it again?

@dertuxmalwieder
Copy link
Author

Sadly, it does not.

@tsteur
Copy link
Member

tsteur commented Oct 22, 2019

Do you know if you have any custom configurations in your config/config.ini.php? Any chance you have eg enable_processing_unique_visitors_day disabled? By looking at the image I suppose you're viewing day when this happens?

tsteur added a commit that referenced this issue Oct 22, 2019
refs #15033 
it might fix that issue

fixes a regression from #14996

When you have the Visits over time for example in the dashboard, view day period, select unique visitors, then select year period, it will then show visits metric instead of unique visitors because unique visitors is not available for year. The visits metric will not show any data though because it had the `&columns=nb_unique_visitors` param applied and the visits metric was never fetched. That's because in #14996 the metric was replaced after the dataTable was being requested. Trying to do this now before requesting dataTable too. Not sure what other regressions this could potentially introduce...
@tsteur
Copy link
Member

tsteur commented Oct 22, 2019

Any chance you could try this patch @dertuxmalwieder ? https://github.com/matomo-org/matomo/pull/15038/files

@dertuxmalwieder
Copy link
Author

dertuxmalwieder commented Oct 22, 2019

The patch fixes it! :-) Thank you.

No custom configuration involved. I'll better not update to rc2 ... ?

tsteur added a commit that referenced this issue Oct 22, 2019
refs #15033 
it might fix that issue

fixes a regression from #14996

When you have the Visits over time for example in the dashboard, view day period, select unique visitors, then select year period, it will then show visits metric instead of unique visitors because unique visitors is not available for year. The visits metric will not show any data though because it had the `&columns=nb_unique_visitors` param applied and the visits metric was never fetched. That's because in #14996 the metric was replaced after the dataTable was being requested. Trying to do this now before requesting dataTable too. Not sure what other regressions this could potentially introduce...
@tsteur tsteur closed this as completed Oct 22, 2019
@tsteur tsteur added Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Oct 22, 2019
@mattab mattab added this to the 3.12.0 milestone Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

No branches or pull requests

3 participants