Some overlay improvements #15032
Merged
Some overlay improvements #15032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs #14835 First fix improves the loading when you have eg configured https://fooBar.com as a site url, and the domain in the url is foobar.com The second fix is event.data related where in this case a website was firing an event and the site was posting event.data as an object
tsteur
added
Pull Request WIP
sgiehl
approved these changes
Oct 28, 2019
diosmosis
pushed a commit
that referenced
this pull request
Nov 6, 2019
refs #14835 First fix improves the loading when you have eg configured https://fooBar.com as a site url, and the domain in the url is foobar.com The second fix is event.data related where in this case a website was firing an event and the site was posting event.data as an object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #14835
First fix improves the loading when you have eg configured
https://fooBar.com as a site url, and the domain in the url is foobar.com
The second fix is event.data related where in this case a website was firing an event and the site was posting event.data as an object
They don't fix the actual issue but make it more reliable