Fix possible error in rowevolution for reports with fixed view types #15028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
Bug
|
restarted the UI build https://travis-ci.org/matomo-org/matomo/jobs/600589983 hoping it runs through in time ... |
|
Restarting the job again as it didn't finish in time... most tests succeeded though from the ones that finished. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a report has a fixed view type (by implementing
alwaysUseDefaultViewDataTable) the row evolution popover might throw an error as it tries to render this default view type instead of the rowevolution graph.fixes DEV-81