Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #15024

Closed
wants to merge 2 commits into from
Closed

Conversation

llopen-sourcell
Copy link

No description provided.

Copy link
Member

@Findus23 Findus23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Honestly hardly anyone reads this README, so if you want to contribute to Matomo, it would be far more useful if you could take a look at the application itself.

If you need any help getting started, just contact me.

@@ -73,7 +73,7 @@ and we need your help to make Matomo better… Why not participate in a useful p

The Matomo project uses an ever-expanding comprehensive set of thousands of unit tests and hundreds of automated integration tests, system tests, JavaScript tests, and screenshot UI tests, running on a continuous integration server as part of its software quality assurance. [Learn more](https://developer.matomo.org/guides/tests)

We use [BrowserStack.com](https://www.browserstack.com/) testing tool to help check the Matomo user interface is compatible with many browsers.
We use [BrowserStack.com](https://www.browserstack.com/) testing tool to help check the Matomo user interface that is compatible with many browsers.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sentence doesn't make any sence with the added that. If one insists on adding it, then it should be after check.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I am just starting out with contributing to open source, I will try to give much better contributions from now on, it will be good if you can help me with this.

@sgiehl sgiehl added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Nov 10, 2019
@sgiehl
Copy link
Member

sgiehl commented Nov 10, 2019

@llopen-sourcell Are you going to improve this PR any further? As it already has conflicts it might be easier for you to close this one and create a new one

@sgiehl
Copy link
Member

sgiehl commented Jan 27, 2020

@llopen-sourcell We moved forward to developing Matomo 4, based on the branch 4.x-dev. I will close this PR. Feel free to recreate a PR based on the new branch. Cheers

@sgiehl sgiehl closed this Jan 27, 2020
@mattab mattab added this to the Backlog (Help wanted) milestone Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants