Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not prepend composer autoloader #15019

Merged
merged 1 commit into from Oct 22, 2019
Merged

Do not prepend composer autoloader #15019

merged 1 commit into from Oct 22, 2019

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Oct 17, 2019

See https://getcomposer.org/doc/06-config.md#prepend-autoloader to fix matomo-org/matomo-for-wordpress#19

Can we not prepend the autoloader? Basically it should pass the argument false here: https://github.com/matomo-org/wp-matomo/blob/master/app/vendor/composer/autoload_real.php#L52

What is happening is that in this case the composer autoloader from cookiebot is registered, then some PHP-DI files are loaded, then our composer autoloader is registered, and suddenly it starts loading PHP-DI files from our vendor directory and these classes are not compatible. I reckon setting the parameter fixes that issue

@tsteur tsteur added the Needs Review PRs that need a code review label Oct 17, 2019
@tsteur tsteur added this to the 3.12.0 milestone Oct 17, 2019
@mattab mattab modified the milestones: 3.12.0, 3.13.0 Oct 22, 2019
@mattab mattab merged commit 19a18bf into 3.x-dev Oct 22, 2019
@mattab mattab modified the milestones: 3.13.0, 3.12.0 Oct 22, 2019
@sgiehl sgiehl deleted the composerautoload branch February 10, 2020 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Matomo Analytics cannot be used when using the Cookiebot plugin.
2 participants