Fix build failures #15016
Merged
Fix build failures #15016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
October 10, 2019 15:02
…allows subtable IDs to be hidden)
tsteur
reviewed
Oct 17, 2019
| @@ -63,7 +63,7 @@ public function getApiForTesting() | |||
| 'date' => '2010-01-01', | |||
| 'periods' => 'year', | |||
| 'testSuffix' => 'phpSerialized', | |||
| 'format' => 'original', | |||
| 'format' => 'php', | |||
There was a problem hiding this comment.
@katebutler as discussed we probably need to adjust instead the original handler to respect hideIdSubDatatable. The test was added to ensure when the dataTable object is serialized that no random information is being added see 46ed8c2 . But now an array is serialized and the actual logic is no longer tested. If possible be good to still use original and also add a comment that this test is testing the serialized DataTable
tsteur
reviewed
Oct 20, 2019
plugins/API/Renderer/Original.php
Outdated
|
|
||
| public function removeIdSubDataTables($response) | ||
| { | ||
| $response = preg_replace('/"subtableId";i:[\d]+;/', '', $response); |
There was a problem hiding this comment.
@katebutler to possibly avoid regexes would it be better to do something similar as in PHP renderer where we iterate over all rows and then call in this case $row->removeSubtable() like
if ($this->hide...) {
foreach ($table->getRows() as $row) {
$row->removeSubtable();
}
}haven't tested but could work
added 5 commits
October 21, 2019 11:07
…cted file; force rowMetadata 'segment' value to string type
mattab
added
c: Tests & QA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.