Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some sparkline issue fatal errors #15015

Closed
wants to merge 1 commit into from
Closed

Fix some sparkline issue fatal errors #15015

wants to merge 1 commit into from

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Oct 16, 2019

Failed for me locally when switching metric in evolution graph

@tsteur
Fix some sparkline issue failing request
9b48f08 
Failed for me locally when switching metric in evolution graph
@tsteur tsteur added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Oct 16, 2019
@tsteur tsteur added this to the 3.12.0 milestone Oct 16, 2019
@tsteur
Copy link
Member Author

tsteur commented Oct 16, 2019 •
edited

@mattab now some tests are failing see https://builds-artifacts.matomo.org/matomo-org/matomo/3.x-dev/36568/

What are those points actually meaning in the sparklines? Are the changes maybe expected?

@tsteur tsteur changed the title Fix some sparkline issue failing request Fix some sparkline issue fatal errors Oct 16, 2019
@mattab
Copy link
Member

mattab commented Oct 16, 2019

The changes are not expected, there shouldn't be any change in the sparkline in non-comparison mode 🤔 eg. this one https://builds-artifacts.matomo.org/matomo-org/matomo/3.x-dev/36568/SingleMetricView_goal_metric.png or this one https://builds-artifacts.matomo.org/matomo-org/matomo/3.x-dev/36568/Comparison_visitors_overview_no_compare.png

  • Red point represents the min value,
  • green point the max value,
  • Blue point the last value

@tsteur
Copy link
Member Author

tsteur commented Oct 16, 2019 •
edited

Got some more errors... just realised my vendor was out of date :(

@tsteur tsteur closed this Oct 16, 2019
@tsteur tsteur deleted the sparkline branch October 16, 2019 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.12.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @mattab