Allow wildcard domain for 3rd party cookies to be set explicitly in config.ini.php #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to be able to set a 3rd party cookie's domain explicitly (so that the browser accepts it and sets it to the correct domain), the constructor was adapted to accept a cookie domain parameter. The concerning usages of that constructor were adapted as well. Now it is possible to put a line 'cookie_domain = ",mydomain.tld" ' into the config.ini.php that will be used by piwik.
Extend Cookie constructor to accept domain. Merged accidentially commited master into topic branch
The changes make sure that cookie wildcard domains always follow the pattern ".<domain_name>", independent of the domain that was configured in the config.ini.php for the key "cookie_domain".
|
Can you please rebase/squash these commits into a single one? You can add the key to |
|
Hi, When I put that key into global.ini.php how is it actually interpreted in case I leave the value empty. From my understanding it should be null and not an empty string. Please, can you give me a short hint / link about how or where I can run or let the tests run? |
|
Closed in order to be replaced by request with squashed commits. |
|
No need to close - you can squash and then push -f to the same branch. The PR will automatically update. |
|
Ah, sorry, was looking for that solution. New request already open. Now I know for the next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for the enhancements discussed in this thread: http://forum.piwik.org/read.php?2,107159,page=1#msg-107379
Please note that in order that this feature can work propperly an entry in the config.ini.php must be set. The key for that entry is "cookie_domain". I was not sure whether there must be a default value set somewhere else for that config key. Means: I do not know whether there would be a runtime error in line 418 of Request.php in case that value is not set in config.ini.php.