Work on translating PrivacyManager templates #14999
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Thanks for the work and just a quick note: |
tsteur
reviewed
Oct 13, 2019
| <p> | ||
| Follow the steps below to ask your user for their consents before their data is processed within Matomo. | ||
| {{ 'PrivacyManager_HowToAskConsentNote1'|translate|e('html_attr') }} |
There was a problem hiding this comment.
@maxpereira FYI you only need |e('html_attr') when it is part of an HTML attribute like content-title="..." above. In here for example you should remove |e('html_attr')
|
Awesome @maxpereira very much appreciated. Be great to ping me once you're ready for a review |
|
Thanks for the tip! I’ll continue working on this and make the necessary changes. |
|
ping @maxpereira Any update on this one? Are you still working on it? |
|
The source repository has been deleted meanwhile, so guess there won't be any updates to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work to fix issue #14954