@eldk opened this Issue on October 12th 2019

Hello,

  • Matomo 3.12.0-b7 and b6
  • Firefox 69 or Chromium 79

Except on first load for Visitors/Visits log, link "View visitor profile" is not displayed when :

  • click on next page
  • change number of row to display

To reproduce :

1 - go to Visitor/Visits Log
2 - click at bottom on next or change number of row to display from 10 to another one.

Should you reproduce ?

Thanks,

Eric

@tsteur commented on October 13th 2019 Member

@eldk tried to reproduce this for quite a while but couldn't. Anyone else can reproduce this maybe?

@eldk commented on October 16th 2019

Hello,

Same in 3.12.0-rc1. Maybe this is something in my config. I'll have a look to find missing step(s) to reproduce.

Thanks,

Eric

@tsteur commented on October 16th 2019 Member

Thanks @eldk that be great

@eldk commented on October 17th 2019

Hello,

Webserver access logs :

First access to Visitors/Visits Log - profile links available :

/index.php?forceView=1&viewDataTable=VisitorLog&module=Live&action=getLastVisitsDetails&small=1&idSite=7&period=range&date=2019-10-01,2019-10-17&segment=&showtitle=1&random=7834

Clic on next - profile links missing:

/index.php?date=2019-10-01,2019-10-17&viewDataTable=VisitorLog&smallWidth=true
&hideProfileLink=false
&pageUrlNotDefined=Page+URL+not+defined&forceView=1&module=Live&action=getLastVisitsDetails&small=1&idSite=7&period=range&random=2641&filter_offset=10&totals=0&filter_limit=10&filter_sort_order=desc

Should'nt hideProfileLink=false be hideProfileLink=0 (https://github.com/matomo-org/matomo/search?q=hideProfileLink&unscoped_q=hideProfileLink)?

Removing check on hideProfileLink in twig template make user profile available in first and next pages https://github.com/matomo-org/matomo/blob/0af1f22f728b2bb2232f84ace5f4b5f0c3c60c57/plugins/Live/templates/_dataTableViz_visitorLog.twig#L8 .

{% if visitor.getColumn('visitorId') is not empty %}

As I have one website with public Matomo stats, I've also check if profiles are not displayed for this entity with this modification : they are not as expected.

So the concern seems to be on hideProfileLink ?

Thanks,

Eric

@eldk commented on October 17th 2019

adding

 <pre>
    {{ dump(clientSideParameters.hideProfileLink) }}
</pre>

to piwik/plugins/Live/templates/_dataTableViz_visitorLog.twig

return :

bool(false) on first page

but :

string(5) "false" on next page.

@tsteur commented on October 17th 2019 Member

Yes that makes sense indeed. I'm actually really sorry as I didn't read your issue properly and somehow missed the part it's only around profile link.

This has been an issue for a while by the looks or probably always been an issue if I see this right.

Created https://github.com/matomo-org/matomo/pull/15020

@eldk commented on October 17th 2019

Ok thanks, this is solved.

This Issue was closed on October 17th 2019
Powered by GitHub Issue Mirror