Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visitors/Visits log : View visitor profile link is only displayed on first page #14998

Closed
eldk opened this issue Oct 12, 2019 · 7 comments · Fixed by #15020
Closed

Visitors/Visits log : View visitor profile link is only displayed on first page #14998

eldk opened this issue Oct 12, 2019 · 7 comments · Fixed by #15020
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@eldk
Copy link

eldk commented Oct 12, 2019

Hello,

  • Matomo 3.12.0-b7 and b6
  • Firefox 69 or Chromium 79

Except on first load for Visitors/Visits log, link "View visitor profile" is not displayed when :

  • click on next page
  • change number of row to display

To reproduce :

1 - go to Visitor/Visits Log
2 - click at bottom on next or change number of row to display from 10 to another one.

Should you reproduce ?

Thanks,

Eric

@eldk eldk changed the title Visitors/Visits log : View visitor profile is only diplayed on first page Visitors/Visits log : View visitor profile is only displayed on first page Oct 12, 2019
@tsteur
Copy link
Member

tsteur commented Oct 13, 2019

@eldk tried to reproduce this for quite a while but couldn't. Anyone else can reproduce this maybe?

@eldk
Copy link
Author

eldk commented Oct 16, 2019

Hello,

Same in 3.12.0-rc1. Maybe this is something in my config. I'll have a look to find missing step(s) to reproduce.

Thanks,

Eric

@tsteur
Copy link
Member

tsteur commented Oct 16, 2019

Thanks @eldk that be great

@eldk
Copy link
Author

eldk commented Oct 17, 2019

Hello,

Webserver access logs :

First access to Visitors/Visits Log - profile links available :

/index.php?forceView=1&viewDataTable=VisitorLog&module=Live&action=getLastVisitsDetails&small=1&idSite=7&period=range&date=2019-10-01,2019-10-17&segment=&showtitle=1&random=7834

Clic on next - profile links missing:

/index.php?date=2019-10-01,2019-10-17&viewDataTable=VisitorLog&smallWidth=true
&hideProfileLink=false
&pageUrlNotDefined=Page+URL+not+defined&forceView=1&module=Live&action=getLastVisitsDetails&small=1&idSite=7&period=range&random=2641&filter_offset=10&totals=0&filter_limit=10&filter_sort_order=desc

Should'nt hideProfileLink=false be hideProfileLink=0 (https://github.com/matomo-org/matomo/search?q=hideProfileLink&unscoped_q=hideProfileLink)?

Removing check on hideProfileLink in twig template make user profile available in first and next pages

{% if visitor.getColumn('visitorId') is not empty and not clientSideParameters.hideProfileLink %}
.

{% if visitor.getColumn('visitorId') is not empty %}

As I have one website with public Matomo stats, I've also check if profiles are not displayed for this entity with this modification : they are not as expected.

So the concern seems to be on hideProfileLink ?

Thanks,

Eric

@eldk
Copy link
Author

eldk commented Oct 17, 2019

adding

 <pre>
    {{ dump(clientSideParameters.hideProfileLink) }}
</pre>

to piwik/plugins/Live/templates/_dataTableViz_visitorLog.twig

return :

bool(false) on first page

but :

string(5) "false" on next page.

@tsteur
Copy link
Member

tsteur commented Oct 17, 2019

Yes that makes sense indeed. I'm actually really sorry as I didn't read your issue properly and somehow missed the part it's only around profile link.

This has been an issue for a while by the looks or probably always been an issue if I see this right.

Created #15020

@tsteur tsteur added this to the 3.12.0 milestone Oct 17, 2019
@eldk
Copy link
Author

eldk commented Oct 17, 2019

Ok thanks, this is solved.

@eldk eldk closed this as completed Oct 17, 2019
@eldk eldk changed the title Visitors/Visits log : View visitor profile is only displayed on first page Visitors/Visits log : View visitor profile link is only displayed on first page Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants