Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove not needed angular mocks library from release #14992

Merged
merged 1 commit into from Oct 11, 2019

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Oct 11, 2019

It seems this is only needed for tests but we actually exclude the tests from the release so we can also exclude this in the package.

It seems this is only needed for tests but we actually exclude the tests from the release so we can also exclude this in the package.
@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Oct 11, 2019
@tsteur tsteur added this to the 3.12.0 milestone Oct 11, 2019
@@ -56,3 +56,4 @@ tests/ export-ignore
.scrutinizer.yml export-ignore
.travis.yml export-ignore
PULL_REQUEST_TEMPLATE export-ignore
/libs/bower_components/angular-mocks export-ignore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this lib required for development or why don't we remove it completely then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sgiehl it seems to actually be required in some JS tests for dev. So it would just not be needed in the release.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok

@tsteur tsteur merged commit 1091c61 into 3.x-dev Oct 11, 2019
@tsteur tsteur deleted the export_ignore_mocks branch October 11, 2019 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants