@tsteur opened this Pull Request on October 10th 2019 Member

When auto update is disabled, we probably also don't want to update these resources from GitHub.

If needed I can also introduce a new config setting but reckon auto update also kind of falls into this category maybe? Can also create a new config setting... If so, any thoughts on the wording?

@sgiehl commented on October 11th 2019 Member

Not sure if we should put that into a new config setting. If not we should at least mention it somewhere in the config file and maybe in an FAQ or similar so it's well documented

@tsteur commented on October 11th 2019 Member

@mattab any thoughts?

@mattab commented on October 13th 2019 Member

I have no strong preference so could merge. As Stefan said we would just need to update faqs and the INI setting doc to clarify.

@tsteur commented on October 14th 2019 Member

I was just adding documentation for it and was looking up some things when I noticed it would actually cause a regression as we would always use outdated lists... as soon as an entry is stored in the DB, it would always use the entry from the DB and not the file anymore. So if someone adds enable_auto_update or adds internet features disabled then those users end up always having an outdated list and I would regress this for users who have already disabled enable_auto_update. I'll hook into scheduled tasks instead.

This Pull Request was closed on October 14th 2019
Powered by GitHub Issue Mirror