Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable update of some resources when auto update is disabled #14989

Closed
wants to merge 1 commit into from

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Oct 10, 2019

When auto update is disabled, we probably also don't want to update these resources from GitHub.

If needed I can also introduce a new config setting but reckon auto update also kind of falls into this category maybe? Can also create a new config setting... If so, any thoughts on the wording?

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Oct 10, 2019
@tsteur tsteur added this to the 3.12.0 milestone Oct 10, 2019
@sgiehl
Copy link
Member

sgiehl commented Oct 11, 2019

Not sure if we should put that into a new config setting. If not we should at least mention it somewhere in the config file and maybe in an FAQ or similar so it's well documented

@tsteur
Copy link
Member Author

tsteur commented Oct 11, 2019

@mattab any thoughts?

@mattab
Copy link
Member

mattab commented Oct 13, 2019

I have no strong preference so could merge. As Stefan said we would just need to update faqs and the INI setting doc to clarify.

@tsteur
Copy link
Member Author

tsteur commented Oct 14, 2019

I was just adding documentation for it and was looking up some things when I noticed it would actually cause a regression as we would always use outdated lists... as soon as an entry is stored in the DB, it would always use the entry from the DB and not the file anymore. So if someone adds enable_auto_update or adds internet features disabled then those users end up always having an outdated list and I would regress this for users who have already disabled enable_auto_update. I'll hook into scheduled tasks instead.

@tsteur tsteur closed this Oct 14, 2019
@tsteur tsteur deleted the autoupdate branch October 14, 2019 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants