Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sparklines don't load anymore in Comparison mode #14985

Closed
mattab opened this issue Oct 10, 2019 · 0 comments · Fixed by #14997
Closed

Sparklines don't load anymore in Comparison mode #14985

mattab opened this issue Oct 10, 2019 · 0 comments · Fixed by #14997
Assignees
@sgiehl
Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
3.12.0

Comments

@mattab
Copy link
Member

mattab commented Oct 10, 2019

In Acquisition > Overview at url or in Visitors > Overview at url this is what we see:

Screenshot from 2019-10-10 17-18-58

-> The Sparklines graphs don't display. Some error is preventing them from loading.

maybe this has regressed recently as the sparklines used to work in comparison mode?
@mattab mattab added Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Oct 10, 2019
@mattab mattab added this to the 3.12.0 milestone Oct 10, 2019
@sgiehl sgiehl self-assigned this Oct 11, 2019
@sgiehl sgiehl mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.12.0
Development

Successfully merging a pull request may close this issue.

Fix pass by reference error when generating comparison sparklines matomo-org/matomo
2 participants
@mattab @sgiehl