Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgradephp - unit test failures #1498

Closed
robocoder opened this issue Jul 22, 2010 · 7 comments
Closed

upgradephp - unit test failures #1498

robocoder opened this issue Jul 22, 2010 · 7 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@robocoder
Copy link
Contributor

If the json extension is disabled (e.g., --disable-json) or missing (e.g., for php 5.1.x, json is an optional PECL extension), the unit tests fail due to differences in the compatibility function. (One of the failures may be a bug.)

@robocoder
Copy link
Contributor Author

Attachment:
all_tests.html

@mattab
Copy link
Member

mattab commented Jul 22, 2010

It looks like all tests but 1 are failign because of encoding differences of utf8 characters, which is OK

one bug however fails because numeric indexes are not exported in the array, as expected

string(150) "{"Limitation":["Multi dimensional arrays is only supported by format=JSON","Known limitation"],"Second Dimension":[true,false,1,0,152,"test",["end"]]}"

string(155) "{"Limitation":["Multi dimensional arrays is only supported by format=JSON","Known limitation"],"Second Dimension":[true,false,1,0,152,"test",{"42":"end"}]}"

very low priority bug as all API arrays should never rely on numeric indexes anyway. vote for wontfix...

@robocoder
Copy link
Contributor Author

We'll have to figure out a workaround. When Hudson is fully configured, the php 5.1.x builds will be continuously failing as a result, and at the moment, Piwik claims to still support php 5.1.3 and above.

@mattab
Copy link
Member

mattab commented Jul 23, 2010

for the numeric index, i'll remove this test case from the array.

can you think of a solution to encoding issues? otherwise, we can hijack these tests for this specific build ;)

@mattab
Copy link
Member

mattab commented Jul 23, 2010

because don't get me wrong, I want hudson sunny before 1.0 :)

@robocoder
Copy link
Contributor Author

(In [3230]) fixes #1498

@robocoder
Copy link
Contributor Author

(In [3236]) refs #1498 - really fix it this time

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

2 participants