@tsteur opened this Pull Request on October 9th 2019 Member

Not sure this could be causing any issues?

@tsteur commented on October 15th 2019 Member

@sgiehl or @mattab any thoughts on this? Was reading https://www.php.net/manual/en/function.session-cache-limiter.php

I understand it won't send eg the Cache-Control: no-store, no-cache, must-revalidate, post-check=0, pre-check=0 .... Pragma: no-cache ... if headers were already sent. We don't really want this, but when this happens, we can't change things anymore anyway. The default is nocache see https://www.php.net/manual/en/session.configuration.php#ini.session.cache-limiter so it should all be fine even if we can't set it specifically. It would only be an issue if the script is eg embedded in WP-Matomo.

@mattab commented on October 15th 2019 Member

Code change looks fine. just checked and this code is from 11 years ago so maybe the default changed and now it's not that important :watch: https://github.com/matomo-org/matomo/commit/23ad6dfa4e9413ee0fdb571bf8c69efe75ec5265

This Pull Request was closed on October 15th 2019
Powered by GitHub Issue Mirror