@katebutler opened this Pull Request on October 8th 2019 Member

Fixes #12426

@DuplicatePR-bot commented on October 9th 2019

Hi there! This pull request looks like it might be a duplicate of #14137, since it has the same issue number , similar commits, and similar changed files.

To improve our bot, you can help us out by clicking one of the options below:

  • This pull request is a duplicate, so this comment was useful. check
  • This pull request is not a duplicate, but this comment was useful nevertheless. check
  • This pull request is not a duplicate, so this comment was not useful. check
  • I do not need this service, so this comment was not useful. check

This bot is currently in its alpha stage, and we are only sending at most one comment per repository. If you are interested in using our bot in the future, please subscribe. If you would like to learn more, see our web page.

@tsteur commented on October 10th 2019 Member

@katebutler it's not working for me. I think the problem is that you're trying to set a config value directly which doesn't work

Config::getInstance()->General['noreply_email_name'] = Common::unsanitizeInputValue(Common::getRequestVar('mailFromName', ''));

instead something like this:

$general = Config::getInstance()->General
$general['noreply_email_name'] = Common::unsanitizeInputValue(Common::getRequestVar('mailFromName', ''));
...
Config::getInstance()->General = $general;
@tsteur commented on October 10th 2019 Member

fyi @katebutler merging now... works now... made a minor tweak that when no address is configured it will use the default value as otherwise sending mails likely fails and making sure to validate the configured address that it looks like an email etc.

This Pull Request was closed on October 10th 2019
Powered by GitHub Issue Mirror