New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow noreply email address/from to be set in admin panel #14975
Conversation
Hi there! This pull request looks like it might be a duplicate of #14137, since it has the same issue number , similar commits, and similar changed files. To improve our bot, you can help us out by clicking one of the options below: This bot is currently in its alpha stage, and we are only sending at most one comment per repository. If you are interested in using our bot in the future, please subscribe. If you would like to learn more, see our web page. |
@katebutler it's not working for me. I think the problem is that you're trying to set a config value directly which doesn't work
instead something like this: $general = Config::getInstance()->General
$general['noreply_email_name'] = Common::unsanitizeInputValue(Common::getRequestVar('mailFromName', ''));
...
Config::getInstance()->General = $general; |
fyi @katebutler merging now... works now... made a minor tweak that when no address is configured it will use the default value as otherwise sending mails likely fails and making sure to validate the configured address that it looks like an email etc. |
Fixes #12426