Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new feature to disable custom logo feature #14972

Closed
tsteur opened this issue Oct 8, 2019 · 2 comments · Fixed by #14982
Closed

Add new feature to disable custom logo feature #14972

tsteur opened this issue Oct 8, 2019 · 2 comments · Fixed by #14982
Assignees
@katebutler
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone
3.12.0

Comments

@tsteur
Copy link
Member

tsteur commented Oct 8, 2019

  • Add a new setting enable_custom_logo = 1 under [General] in the config
  • When feature is disabled, throw an exception in CoreAdminHome.setBrandingSettings API
  • When feature is disabled, do not show the div for that setting in CoreAdminHome/generalSettings.twig.
  • When feature is disabled, throw an exception in CoreAdminHome controller in uploadCustomLogo action.

We don't need to change anything else.
@tsteur tsteur added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Oct 8, 2019
@tsteur tsteur added this to the 3.12.0 milestone Oct 8, 2019
@alcalyn
Copy link
Contributor

alcalyn commented Oct 9, 2019 •
edited

What is the user need behind this issue ?

I'm not sure on how to test it

@tsteur
Copy link
Member Author

tsteur commented Oct 9, 2019

@alcalyn someone is already working on this issue. Thanks for asking though! Very appreciated.

@katebutler katebutler mentioned this issue Oct 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katebutler katebutler

Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
3.12.0
Development

Successfully merging a pull request may close this issue.

Add config setting to disable custom logo upload matomo-org/matomo
3 participants
@tsteur @alcalyn @katebutler