Log stack traces for PHP warnings etc #14961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katebutler
added
the
not-in-changelog
|
BTW @katebutler there are some failing tests https://travis-ci.org/matomo-org/matomo/jobs/594801494 and https://travis-ci.org/matomo-org/matomo/jobs/594801495#L818 and as discussed be good to remove the newline. |
|
@katebutler I'm thinking this failing test might be due to this change? https://travis-ci.org/matomo-org/matomo/jobs/594907204#L817 |
tsteur
reviewed
Oct 9, 2019
core/ErrorHandler.php
Outdated
| @@ -161,8 +161,12 @@ public static function errorHandler($errno, $errstr, $errfile, $errline) | |||
| case E_DEPRECATED: | |||
| case E_USER_DEPRECATED: | |||
| default: | |||
| $context = array('trace' => debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS)); | |||
There was a problem hiding this comment.
@katebutler could we add a limit here of say max 15 last traces? There is a second parameter $limit that can be set.
makes it also easier for users to share the trace since they don't need to remove any paths
This was referenced Oct 10, 2019
mattab
removed
the
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the full stack in the log message when writing to file only. The log message for other handlers (web notifications and database) will not be changed.