Remove duplicate decodeURIComponent call in segmentcontroller #14952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@katebutler it seems to work for my case but now failing for this case: https://builds-artifacts.matomo.org/matomo-org/matomo/3.x-dev/36240/SegmentSelectorEditorTest_saved_details.png I wonder if that's because some segments might be double encoded while some might not or so... I reckon we could just try to decode it there, and if it fails return the regular version... like try {
return decode...(newMetric.value)
} catch (e){
return newMetric.value
} |
… are stored double-encoded
|
@tsteur Have added a second |
mattab
added
the
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14943
This line is not needed as the
decodeURIComponentis already done whenevernewmetric.valueis set.