Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip unnecessary validation on report unsubscribe #14942

Merged
merged 4 commits into from Oct 7, 2019
Merged

Skip unnecessary validation on report unsubscribe #14942

merged 4 commits into from Oct 7, 2019

Conversation

katebutler
Copy link

Fixes #14925, which was caused by the subscription containing a report from a plugin which had been deactivated.

@katebutler katebutler added the Needs Review PRs that need a code review label Oct 2, 2019
@katebutler katebutler added this to the 3.12.0 milestone Oct 2, 2019
@tsteur
Copy link
Member

tsteur commented Oct 4, 2019

@katebutler some tests are failing see https://travis-ci.org/matomo-org/matomo/jobs/593226856#L907

It seems it's not clearing the scheduled reports cache in API::public static $cache

@tsteur tsteur merged commit 1bf1b1f into 3.x-dev Oct 7, 2019
@tsteur tsteur deleted the 14925 branch October 7, 2019 01:03
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.12.0
Development

Successfully merging this pull request may close these issues.

Unsubscribing from email report leads to error
3 participants
@katebutler @tsteur @mattab