Tested locally, seems to work. Ready for another review.
Applied more review feedback.
Worked nicely for me @diosmosis . The only thing I would maybe change is to maybe instead of using
last1 using at least
last2 always or could maybe always add
+1 period? not needed maybe though but could prevent some random edge cases and be maybe safer re timezone or other hard to find issues. Might not be needed though as it would maybe only hide a problem. Up to you.
We'll merge this after the next 3.13. release just to give it more time to test during a beta.
I'll add this to 3.13.1
@diosmosis seems there are 2 more integration tests failing although not sure if the 2nd test is maybe fixed by now as it was maybe caused by some other test? https://travis-ci.org/matomo-org/matomo/jobs/616834354#L826-L879 .
If you have time, could you update the test and then merge?
@diosmosis when you have some time could you have a look at this?