Ignore option inserts if they fail at MySQL level #14931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem I'm having is that I'm using a different DB backend which logs/shows errors in their DB layer. In this case what happens is that we're often calling `Option::set()` and the value doesn't actually change. In this case because no row changed, the update `$result` will be `0` and therefore it will try to insert the value which will fail because of duplicate entry. I know we're catching the exception but in this case we can as well IGNORE any failure when we catch any exception anyway. This way there will be no more errors shown in the UI when using a different DB layer. I know the same problem can happen in other queries we do as well but it's particularly annoying with the option queries currently.
tsteur
added
not-in-changelog
tsteur
added
the
Help wanted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem I'm having is that I'm using a different DB backend which logs/shows errors in their DB layer. In this case what happens is that we're often calling
Option::set()and the value doesn't actually change. In this case because no row changed, the update$resultwill be0and therefore it will try to insert the value which will fail because of duplicate entry.I know we're catching the exception but in this case we can as well IGNORE any failure when we catch any exception anyway. This way there will be no more errors shown in the UI when using a different DB layer. I know the same problem can happen in other queries we do as well but it's particularly annoying with the option queries currently.