@tsteur opened this Pull Request on October 1st 2019 Member

Problem I'm having is that I'm using a different DB backend which logs/shows errors in their DB layer. In this case what happens is that we're often calling Option::set() and the value doesn't actually change. In this case because no row changed, the update $result will be 0 and therefore it will try to insert the value which will fail because of duplicate entry.
I know we're catching the exception but in this case we can as well IGNORE any failure when we catch any exception anyway. This way there will be no more errors shown in the UI when using a different DB layer. I know the same problem can happen in other queries we do as well but it's particularly annoying with the option queries currently.

This Pull Request was closed on October 2nd 2019
Powered by GitHub Issue Mirror